Add .test-outcome.log support to test.dart

Add .test-outcome.log support to test.dart

R=ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30768

[kustermann, 2013-11-28 17:45:26]

The plan is to enable this on the log, archive it and mine the data ...

[ricow1, 2013-11-28 18:06:15]

LGTM

https://codereview.chromium.org/95603002/diff/1/dart/tools/testing/dart/test_...
File dart/tools/testing/dart/test_options.dart (right):

https://codereview.chromium.org/95603002/diff/1/dart/tools/testing/dart/test_...
dart/tools/testing/dart/test_options.dart:306: '".test-outcome.log" file.',
us the filename getter function here as well

https://codereview.chromium.org/95603002/diff/1/dart/tools/testing/dart/test_...
File dart/tools/testing/dart/test_progress.dart (right):

https://codereview.chromium.org/95603002/diff/1/dart/tools/testing/dart/test_...
dart/tools/testing/dart/test_progress.dart:197: *  {
specify what the duration is stored in

https://codereview.chromium.org/95603002/diff/1/dart/tools/testing/dart/test_...
dart/tools/testing/dart/test_progress.dart:225: ['mode', 'compiler', 'runtime',
'checked', 'host_checked', 'minified',
+arch, +use-sdk, +

https://codereview.chromium.org/95603002/diff/1/dart/tools/testing/dart/test_...
dart/tools/testing/dart/test_progress.dart:243: double duration =
output.time.inMicroseconds/1000.0;
inMilliseconds? (I don't really care about sub millisecond accuracy - we are,
after all, spawning a process for these

https://codereview.chromium.org/95603002/diff/1/dart/tools/testing/dart/test_...
dart/tools/testing/dart/test_progress.dart:267:
fd.writeStringSync("${JSON.encode(record)}\n");
I am not sure we should do this sync, could actually add to our cycle time since
we do this for every test

[kustermann, 2013-11-28 20:51:02]

Thanks.

https://codereview.chromium.org/95603002/diff/1/dart/tools/testing/dart/test_...
File dart/tools/testing/dart/test_options.dart (right):

https://codereview.chromium.org/95603002/diff/1/dart/tools/testing/dart/test_...
dart/tools/testing/dart/test_options.dart:306: '".test-outcome.log" file.',
On 2013/11/28 18:06:16, ricow1 wrote:
> us the filename getter function here as well

Done.

https://codereview.chromium.org/95603002/diff/1/dart/tools/testing/dart/test_...
File dart/tools/testing/dart/test_progress.dart (right):

https://codereview.chromium.org/95603002/diff/1/dart/tools/testing/dart/test_...
dart/tools/testing/dart/test_progress.dart:197: *  {
On 2013/11/28 18:06:16, ricow1 wrote:
> specify what the duration is stored in

Done.

https://codereview.chromium.org/95603002/diff/1/dart/tools/testing/dart/test_...
dart/tools/testing/dart/test_progress.dart:225: ['mode', 'compiler', 'runtime',
'checked', 'host_checked', 'minified',
On 2013/11/28 18:06:16, ricow1 wrote:
> +arch, +use-sdk, +

Actually I would like to include only configuration specific flags. Not the
global flags.

I added 'arch', 'use_sdk', 'system', 'vm_options', 'use_sdk'.

I think these are all we care about.

https://codereview.chromium.org/95603002/diff/1/dart/tools/testing/dart/test_...
dart/tools/testing/dart/test_progress.dart:243: double duration =
output.time.inMicroseconds/1000.0;
On 2013/11/28 18:06:16, ricow1 wrote:
> inMilliseconds? (I don't really care about sub millisecond accuracy - we are,
> after all, spawning a process for these

I think it doesn't hurt if we have milliseconds with 3 digits after the dot.

https://codereview.chromium.org/95603002/diff/1/dart/tools/testing/dart/test_...
dart/tools/testing/dart/test_progress.dart:267:
fd.writeStringSync("${JSON.encode(record)}\n");
On 2013/11/28 18:06:16, ricow1 wrote:
> I am not sure we should do this sync, could actually add to our cycle time
since
> we do this for every test

I tested it on my linux machine and it had zero impact. I just made it
synchronous as we do with the flaky log.

I'll make it async now.

[kustermann, 2013-11-29 08:29:32]

Committed patchset #2 manually as r30768 (presubmit successful).