Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issue 955923002: Reapply "Use an enum in embedded_names as input to JS_GET_NAME." (Closed)

Created:
5 years, 10 months ago by karlklose
Modified:
5 years, 10 months ago
Reviewers:
herhut
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -41 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 3 chunks +7 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 1 chunk +16 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +8 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/foreign_helper.dart View 2 chunks +3 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_helper.dart View 8 chunks +19 lines, -14 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_mirrors.dart View 7 chunks +8 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_names.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart View 1 chunk +13 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
5 years, 10 months ago (2015-02-25 07:20:39 UTC) #1
herhut
LGTM This cl is not really related to the referenced bug. Still, thanks for fixing ...
5 years, 10 months ago (2015-02-25 07:47:54 UTC) #2
karlklose
5 years, 10 months ago (2015-02-25 10:34:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44020 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698