Pass SourceInformation through the CPS IR.

Pass SourceInformation through the CPS IR.

BUG=
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44126

[Johnni Winther, 2015-02-24 08:29:29]

johnniwinther@google.com changed reviewers:
+ floitsch@google.com

[Johnni Winther, 2015-02-24 08:29:30]

https://codereview.chromium.org/955543004/diff/20001/pkg/compiler/lib/src/cps...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart (right):

https://codereview.chromium.org/955543004/diff/20001/pkg/compiler/lib/src/cps...
pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart:702: ir.Primitive
buildStaticGet(Element element,
The JS backend doesn't support static-get yet, so this is not tested.

[floitsch, 2015-02-24 19:58:12]

LGTM.

https://codereview.chromium.org/955543004/diff/20001/pkg/compiler/lib/src/cps...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart (right):

https://codereview.chromium.org/955543004/diff/20001/pkg/compiler/lib/src/cps...
pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart:1736: SourceInformation
buildGet(ast.Node node) => null;
The "build" reads redundant at the use-sites, but I guess removing them wouldn't
be great either... :(

https://codereview.chromium.org/955543004/diff/20001/pkg/compiler/lib/src/cps...
pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart:1764:
SourceInformationBuilder forContext(AstElement element) {
I'm not sure I like this. Is this just to avoid having a
"createSourceInformationBuilderFor(element)" function?

Or does the returned builder have a relationship to the current builder?

https://codereview.chromium.org/955543004/diff/20001/pkg/compiler/lib/src/io/...
File pkg/compiler/lib/src/io/source_information.dart (right):

https://codereview.chromium.org/955543004/diff/20001/pkg/compiler/lib/src/io/...
pkg/compiler/lib/src/io/source_information.dart:98:
sb.write('[${startPosition.line + 1},${startPosition.column + 1}]');
Is this just to make it easier to reason? That is, because editors start with
line/column 1 ?

Add a comment.

https://codereview.chromium.org/955543004/diff/20001/tests/compiler/dart2js/j...
File tests/compiler/dart2js/js_backend_cps_ir_source_information_test.dart
(right):

https://codereview.chromium.org/955543004/diff/20001/tests/compiler/dart2js/j...
tests/compiler/dart2js/js_backend_cps_ir_source_information_test.dart:12: import
'package:compiler/src/apiimpl.dart'
Since you keep "Element" and "ClassElement" on the same line (18), do the same
here?

[Johnni Winther, 2015-02-26 10:21:35]

https://codereview.chromium.org/955543004/diff/20001/pkg/compiler/lib/src/cps...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart (right):

https://codereview.chromium.org/955543004/diff/20001/pkg/compiler/lib/src/cps...
pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart:1764:
SourceInformationBuilder forContext(AstElement element) {
On 2015/02/24 19:58:12, floitsch wrote:
> I'm not sure I like this. Is this just to avoid having a
> "createSourceInformationBuilderFor(element)" function?
> 
> Or does the returned builder have a relationship to the current builder?

It is made to handle the choice of strategy at one point. A
[createSourceInformationBuilderFor] doesn't work since the decision should be
taken in the IrBuilderTask but new SourceInformatioBuilder object needs to be
created by the visitor.

[Johnni Winther, 2015-03-02 11:45:42]

Committed patchset #6 (id:100001) manually as 44126 (presubmit successful).

[Johnni Winther, 2015-03-02 11:48:14]

https://codereview.chromium.org/955543004/diff/20001/pkg/compiler/lib/src/io/...
File pkg/compiler/lib/src/io/source_information.dart (right):

https://codereview.chromium.org/955543004/diff/20001/pkg/compiler/lib/src/io/...
pkg/compiler/lib/src/io/source_information.dart:98:
sb.write('[${startPosition.line + 1},${startPosition.column + 1}]');
On 2015/02/24 19:58:12, floitsch wrote:
> Is this just to make it easier to reason? That is, because editors start with
> line/column 1 ?
> 
> Add a comment.

Done.