Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 955543002: Move a bunch of src/ files into subdirectories. (Closed)

Created:
5 years, 10 months ago by nweiz
Modified:
5 years, 10 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/unittest@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move a bunch of src/ files into subdirectories. This creates the following four subdirectories: * `frontend/`, which is for user-visible libraries exported by `lib/unittest.dart`. * `backend/`, which is for libraries that define the internal structure of test suites and how they're run in a platform- independent manner. * `runner/`, which is for libraries that are specifically useful for the test runner. This includes code that deals with multiple test suites at once as well as platform-specific test running code. * `util/`, which contains various utility libraries that aren't specific to unittest's use-case. Individual utility functions can still go in `lib/util.dart`. * `deprecated/`, which contains deprecated libraries. R=kevmoo@google.com Committed: https://github.com/dart-lang/unittest/commit/aede514bf3e112b05e942cdb264a0a7077e6821c

Patch Set 1 #

Patch Set 2 : Fix library tags #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -2583 lines) Patch
M bin/unittest.dart View 1 chunk +5 lines, -5 lines 0 comments Download
A + lib/src/backend/declarer.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + lib/src/backend/group.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + lib/src/backend/invoker.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + lib/src/backend/live_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + lib/src/backend/live_test_controller.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + lib/src/backend/state.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + lib/src/backend/suite.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + lib/src/backend/test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
D lib/src/configuration.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D lib/src/console_reporter.dart View 1 chunk +0 lines, -231 lines 0 comments Download
D lib/src/dart.dart View 1 chunk +0 lines, -71 lines 0 comments Download
D lib/src/declarer.dart View 1 chunk +0 lines, -94 lines 0 comments Download
A + lib/src/deprecated/configuration.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + lib/src/deprecated/simple_configuration.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + lib/src/deprecated/test_case.dart View 1 1 chunk +1 line, -1 line 0 comments Download
D lib/src/engine.dart View 1 chunk +0 lines, -72 lines 0 comments Download
D lib/src/exit_codes.dart View 1 chunk +0 lines, -58 lines 0 comments Download
D lib/src/expect.dart View 1 chunk +0 lines, -71 lines 0 comments Download
D lib/src/expect_async.dart View 1 chunk +0 lines, -234 lines 0 comments Download
A + lib/src/frontend/expect.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + lib/src/frontend/expect_async.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + lib/src/frontend/future_matchers.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + lib/src/frontend/prints_matcher.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + lib/src/frontend/throws_matcher.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + lib/src/frontend/throws_matchers.dart View 1 1 chunk +1 line, -1 line 0 comments Download
D lib/src/future_matchers.dart View 1 chunk +0 lines, -81 lines 0 comments Download
D lib/src/group.dart View 1 chunk +0 lines, -76 lines 0 comments Download
D lib/src/invoker.dart View 1 chunk +0 lines, -183 lines 0 comments Download
D lib/src/io.dart View 1 chunk +0 lines, -55 lines 0 comments Download
D lib/src/isolate_test.dart View 1 chunk +0 lines, -57 lines 0 comments Download
D lib/src/isolate_wrapper.dart View 1 chunk +0 lines, -48 lines 0 comments Download
D lib/src/live_test.dart View 1 chunk +0 lines, -117 lines 0 comments Download
D lib/src/live_test_controller.dart View 1 chunk +0 lines, -155 lines 0 comments Download
D lib/src/load_exception.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D lib/src/loader.dart View 1 chunk +0 lines, -108 lines 0 comments Download
D lib/src/prints_matcher.dart View 1 chunk +0 lines, -81 lines 0 comments Download
D lib/src/remote_exception.dart View 1 chunk +0 lines, -111 lines 0 comments Download
A + lib/src/runner/console_reporter.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
A + lib/src/runner/engine.dart View 1 1 chunk +5 lines, -5 lines 0 comments Download
A + lib/src/runner/isolate_test.dart View 1 1 chunk +7 lines, -7 lines 0 comments Download
A + lib/src/runner/load_exception.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + lib/src/runner/loader.dart View 1 3 chunks +6 lines, -6 lines 0 comments Download
A + lib/src/runner/vm_listener.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
D lib/src/simple_configuration.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D lib/src/state.dart View 1 chunk +0 lines, -106 lines 0 comments Download
D lib/src/suite.dart View 1 chunk +0 lines, -24 lines 0 comments Download
D lib/src/test.dart View 1 chunk +0 lines, -24 lines 0 comments Download
D lib/src/test_case.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D lib/src/throws_matcher.dart View 1 chunk +0 lines, -112 lines 0 comments Download
D lib/src/throws_matchers.dart View 1 chunk +0 lines, -44 lines 0 comments Download
A + lib/src/util/dart.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + lib/src/util/exit_codes.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + lib/src/util/io.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + lib/src/util/isolate_wrapper.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + lib/src/util/remote_exception.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
D lib/src/vm_listener.dart View 1 chunk +0 lines, -115 lines 0 comments Download
M lib/unittest.dart View 1 chunk +18 lines, -44 lines 0 comments Download
M test/console_reporter_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/declarer_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M test/engine_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M test/expect_async_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/invoker_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M test/loader_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M test/runner_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/utils.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M test/vm_listener_test.dart View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
5 years, 10 months ago (2015-02-24 04:38:05 UTC) #1
kevmoo
lgtm
5 years, 10 months ago (2015-02-24 04:46:49 UTC) #2
nweiz
I forgot to fix the library tags; PTAL
5 years, 10 months ago (2015-02-24 05:03:57 UTC) #3
kevmoo
lgtm
5 years, 10 months ago (2015-02-24 05:21:12 UTC) #4
nweiz
5 years, 10 months ago (2015-02-24 20:10:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
aede514bf3e112b05e942cdb264a0a7077e6821c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698