Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 954703002: Update project to match OSS template (Closed)

Created:
5 years, 10 months ago by Søren Gjesse
Modified:
5 years, 10 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/async.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed review comments and added .gitignore and empty .status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -2 lines) Patch
A .gitignore View 1 1 chunk +8 lines, -0 lines 0 comments Download
A .status View 1 1 chunk +4 lines, -0 lines 0 comments Download
A AUTHORS View 1 chunk +6 lines, -0 lines 0 comments Download
A CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
A CONTRIBUTING.md View 1 chunk +33 lines, -0 lines 0 comments Download
M LICENSE View 1 chunk +1 line, -1 line 0 comments Download
M README.md View 1 2 chunks +8 lines, -0 lines 0 comments Download
A codereview.settings View 1 chunk +3 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
5 years, 10 months ago (2015-02-24 10:15:58 UTC) #1
ricow1
lgtm https://codereview.chromium.org/954703002/diff/1/README.md File README.md (right): https://codereview.chromium.org/954703002/diff/1/README.md#newcode27 README.md:27: [tracker]: https://github.com/dart-lang/sample/issues wrong url https://codereview.chromium.org/954703002/diff/1/pubspec.yaml File pubspec.yaml (right): ...
5 years, 10 months ago (2015-02-24 10:18:24 UTC) #2
Søren Gjesse
Added .gitignore and empty .status as well. https://codereview.chromium.org/954703002/diff/1/README.md File README.md (right): https://codereview.chromium.org/954703002/diff/1/README.md#newcode27 README.md:27: [tracker]: https://github.com/dart-lang/sample/issues ...
5 years, 10 months ago (2015-02-24 10:27:13 UTC) #3
Søren Gjesse
5 years, 10 months ago (2015-02-24 10:27:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c17e74652b7c0f1ff5f3b728ae7a307da654b42d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698