Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 954063002: Use an interning table to compare and hash FileBasedSource objects. (Closed)

Created:
5 years, 10 months ago by Paul Berry
Modified:
5 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use an interning table to compare and hash FileBasedSource objects. Speeds up analysis by about 8%. Note: the interning table uses both the file path and the URI to distinguish FileBasedSource objects. This should eliminate the strange behaviors we would see in the rare case where a single URI would get associated with multiple file paths (see dartbug.com/22555). The interning table is never flushed over the lifetime of the application. In practice this should not be a problem, because it only contains one entry per filename/URI, and the total number of filenames/URIs analyzed during the course of execution should always be small. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=44026

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M pkg/analyzer/lib/src/generated/source_io.dart View 5 chunks +23 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 10 months ago (2015-02-25 00:25:54 UTC) #2
Brian Wilkerson
LGTM
5 years, 10 months ago (2015-02-25 01:21:04 UTC) #3
Paul Berry
5 years, 10 months ago (2015-02-25 18:11:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44026 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698