Issue 954013002: Replace try/finally with PerformanceTag.makeCurrentWhile().

Issue 954013002: Replace try/finally with PerformanceTag.makeCurrentWhile(). (Closed)

Created:
5 years, 10 months ago by scheglov

Modified:
5 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Replace try/finally with PerformanceTag.makeCurrentWhile(). R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44004

Patch Set 1 #

Total comments: 2

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+116 lines, -226 lines)			Patch
M	pkg/analysis_server/lib/src/analysis_server.dart	View	3 chunks	+2 lines, -12 lines	0 comments	Download
M	pkg/analysis_server/lib/src/channel/byte_stream_channel.dart	View	5 chunks	+6 lines, -19 lines	0 comments	Download
M	pkg/analysis_server/lib/src/channel/web_socket_channel.dart	View	3 chunks	+6 lines, -19 lines	0 comments	Download
M	pkg/analysis_server/lib/src/domain_execution.dart	View	3 chunks	+2 lines, -7 lines	0 comments	Download
M	pkg/analysis_server/lib/src/operation/operation_analysis.dart	View	3 chunks	+4 lines, -13 lines	2 comments	Download
M	pkg/analyzer/lib/src/generated/engine.dart	View	10 chunks	+25 lines, -41 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View	32 chunks	+50 lines, -104 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/source_io.dart	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/utilities_general.dart	View	3 chunks	+17 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/services/lint.dart	View	1 chunk	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/954013002/diff/1/pkg/analysis_server/lib/src/operation/operation_analysis.dart File pkg/analysis_server/lib/src/operation/operation_analysis.dart (right): https://codereview.chromium.org/954013002/diff/1/pkg/analysis_server/lib/src/operation/operation_analysis.dart#newcode226 pkg/analysis_server/lib/src/operation/operation_analysis.dart:226: _updateIndex(server, notices); The execution of _updateIndex is no ...

5 years, 10 months ago (2015-02-24 22:31:07 UTC) #2

scheglov

https://codereview.chromium.org/954013002/diff/1/pkg/analysis_server/lib/src/operation/operation_analysis.dart File pkg/analysis_server/lib/src/operation/operation_analysis.dart (right): https://codereview.chromium.org/954013002/diff/1/pkg/analysis_server/lib/src/operation/operation_analysis.dart#newcode226 pkg/analysis_server/lib/src/operation/operation_analysis.dart:226: _updateIndex(server, notices); On 2015/02/24 22:31:07, Brian Wilkerson wrote: > ...

5 years, 10 months ago (2015-02-24 22:33:05 UTC) #3

scheglov

5 years, 10 months ago (2015-02-24 22:34:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44004 (presubmit successful).

Expand Messages | Collapse Messages