Issue 953863004: When converting files to package URI's, favor longer directory matches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 953863004: When converting files to package URI's, favor longer directory matches. (Closed)

Created:
5 years, 10 months ago by Paul Berry

Modified:
5 years, 10 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

When converting files to package URI's, favor longer directory matches. Longer directory matches in mean that the relative path part of the package URI will be shorter, making it more likely to match user intent. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=44025

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -3 lines)			Patch
	M	pkg/analyzer/lib/source/package_map_resolver.dart	View		1 chunk	+6 lines, -3 lines	0 comments	Download
	M	pkg/analyzer/test/source/package_map_resolver_test.dart	View		1 chunk	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

5 years, 10 months ago (2015-02-25 18:04:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44025 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages