Issue 953323002: Fix broken test of platform version

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 953323002: Fix broken test of platform version (Closed)

Created:
5 years, 10 months ago by Søren Gjesse

Modified:
5 years, 10 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix broken test of platform version The version check regexp expected that additional info was stripped. The dartdoc for Platform.version says that the version is what is before the first space if any. R=ricow@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44021

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	tests/standalone/io/platform_test.dart	View		1 chunk	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

5 years, 10 months ago (2015-02-25 11:46:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44021 (presubmit successful).

Expand Messages | Collapse Messages