dart2js: create constants lazily in the new emitter.

dart2js: create constants lazily in the new emitter.

R=zarah@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44326

[floitsch, 2015-02-24 23:28:51]

floitsch@google.com changed reviewers:
+ zarah@google.com

[floitsch, 2015-02-25 17:06:24]

Made it such that the constants aren't making the C object polymorphic. (Huge
performance win).
PTAL and ping.

[zarah, 2015-02-26 08:01:50]

LGTM

[floitsch, 2015-02-27 12:42:23]

PTAL.
I fixed a few more constants in the native_helper and remove the bad "constants"
reference in the deferred boilerplate.

[zarah, 2015-03-06 09:15:29]

Still lgtm.

[floitsch, 2015-03-06 19:30:26]

Made minor changes.
Will commit on Monday.

Note: this patch uncovered a latent bug in the compiler, where we initialize a
static with a constant that wasn't emitted.

language/compile_time_constant_n_test

https://codereview.chromium.org/952973004/diff/160001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right):

https://codereview.chromium.org/952973004/diff/160001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:156: if (value is
js.LiteralExpression &&
This captures the JS_CONST cases that had a literal expression starting with
"function" in it.

https://codereview.chromium.org/952973004/diff/160001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:430:
deferredCode.add(emitConstants(fragment.constants));
This line was missing.

[floitsch, 2015-03-09 16:37:12]

Committed patchset #9 (id:160001) manually as 44326 (presubmit successful).