Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 952013003: Fix exception handling (Closed)

Created:
5 years, 10 months ago by Brian Wilkerson
Modified:
5 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/analyzer/lib/src/generated/engine.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
Without this change, we loose the stack trace associated with the caught exception.
5 years, 10 months ago (2015-02-24 19:26:38 UTC) #2
scheglov
LGTM
5 years, 10 months ago (2015-02-24 19:54:31 UTC) #3
Brian Wilkerson
5 years, 10 months ago (2015-02-24 20:01:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43995 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698