Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 95183002: Add the index information to network interface (Closed)

Created:
7 years ago by Søren Gjesse
Modified:
7 years ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add the index information to network interface R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=30776

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -15 lines) Patch
M runtime/bin/socket.h View 2 chunks +6 lines, -2 lines 0 comments Download
M runtime/bin/socket.cc View 1 2 chunks +5 lines, -1 line 0 comments Download
M runtime/bin/socket_linux.cc View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/bin/socket_macos.cc View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/bin/socket_patch.dart View 1 2 chunks +8 lines, -9 lines 0 comments Download
M runtime/bin/socket_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/io/socket.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/standalone/io/network_interface_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Søren Gjesse
7 years ago (2013-11-28 15:37:30 UTC) #1
Anders Johnsen
Android seams to be missing. https://codereview.chromium.org/95183002/diff/1/runtime/bin/socket.cc File runtime/bin/socket.cc (right): https://codereview.chromium.org/95183002/diff/1/runtime/bin/socket.cc#newcode452 runtime/bin/socket.cc:452: CObjectIntptr* interface_index = new ...
7 years ago (2013-11-29 08:35:09 UTC) #2
Anders Johnsen
LGTM with previous comments.
7 years ago (2013-11-29 08:35:17 UTC) #3
Søren Gjesse
https://codereview.chromium.org/95183002/diff/1/runtime/bin/socket.cc File runtime/bin/socket.cc (right): https://codereview.chromium.org/95183002/diff/1/runtime/bin/socket.cc#newcode452 runtime/bin/socket.cc:452: CObjectIntptr* interface_index = new CObjectIntptr(CObject::NewIntptr( On 2013/11/29 08:35:10, Anders ...
7 years ago (2013-11-29 10:01:20 UTC) #4
Søren Gjesse
7 years ago (2013-11-29 10:13:23 UTC) #5
Søren Gjesse
7 years ago (2013-11-29 11:18:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r30776 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698