Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 951463005: Small improvements for indexing NameElements. (Closed)

Created:
5 years, 10 months ago by scheglov
Modified:
5 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Small improvements for indexing NameElements. It improves analysis by about 2%. For analyzer + analysis_server indexing takes about 12% now. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44027

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M pkg/analysis_server/lib/src/services/index/index.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/index/store/codec.dart View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 10 months ago (2015-02-25 18:36:09 UTC) #1
Brian Wilkerson
LGTM
5 years, 10 months ago (2015-02-25 18:47:04 UTC) #2
scheglov
5 years, 10 months ago (2015-02-25 18:51:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44027 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698