support more types of expressions

support more types of expressions

R=sigmund@google.com

Committed: https://github.com/dart-lang/static_init/commit/e852273435659d36dd9e9a231af7afb5e47a1e5c

[jakemac, 2015-02-25 18:19:06]

jakemac@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2015-02-25 19:32:08]

https://codereview.chromium.org/951463004/diff/20001/lib/build/initializer_pl...
File lib/build/initializer_plugin.dart (right):

https://codereview.chromium.org/951463004/diff/20001/lib/build/initializer_pl...
lib/build/initializer_plugin.dart:272: if (value is String) value =
_stringValue(value);
we might need to check for instance creations here as well. 

For example, I'm not sure if we handle this correctly:

a.dart:
  @HtmlImport(b.foo);
  library a;

  import 'b.dart' as b;

b.dart:
  const foo = const Foo()
  

This will get normalized to the value `const Foo()` here, I believe

[jakemac, 2015-02-25 20:23:05]

https://codereview.chromium.org/951463004/diff/20001/lib/build/initializer_pl...
File lib/build/initializer_plugin.dart (right):

https://codereview.chromium.org/951463004/diff/20001/lib/build/initializer_pl...
lib/build/initializer_plugin.dart:272: if (value is String) value =
_stringValue(value);
On 2015/02/25 19:32:08, Siggi Cherem (dart-lang) wrote:
> we might need to check for instance creations here as well. 
> 
> For example, I'm not sure if we handle this correctly:
> 
> a.dart:
>   @HtmlImport(b.foo);
>   library a;
> 
>   import 'b.dart' as b;
> 
> b.dart:
>   const foo = const Foo()
>   
> 
> This will get normalized to the value `const Foo()` here, I believe

Above this there is a special case for Identifiers, they aren't evaluated but
just left alone (and prefixed). The `constructor arguments` test has an example
of this.

This code path is just for expressions that aren't simple literals, identifiers,
or constructors.

[Siggi Cherem (dart-lang), 2015-02-25 21:06:33]

lgtm, just double checking below

https://codereview.chromium.org/951463004/diff/20001/lib/build/initializer_pl...
File lib/build/initializer_plugin.dart (right):

https://codereview.chromium.org/951463004/diff/20001/lib/build/initializer_pl...
lib/build/initializer_plugin.dart:272: if (value is String) value =
_stringValue(value);
On 2015/02/25 20:23:05, jakemac wrote:
> On 2015/02/25 19:32:08, Siggi Cherem (dart-lang) wrote:
> > we might need to check for instance creations here as well. 
> > 
> > For example, I'm not sure if we handle this correctly:
> > 
> > a.dart:
> >   @HtmlImport(b.foo);
> >   library a;
> > 
> >   import 'b.dart' as b;
> > 
> > b.dart:
> >   const foo = const Foo()
> >   
> > 
> > This will get normalized to the value `const Foo()` here, I believe
> 
> Above this there is a special case for Identifiers, they aren't evaluated but
> just left alone (and prefixed). The `constructor arguments` test has an
example
> of this.
> 
> This code path is just for expressions that aren't simple literals,
identifiers,
> or constructors.

but is there any case where those could evaluate to a constructor as a result?

[jakemac, 2015-02-25 22:06:08]

https://codereview.chromium.org/951463004/diff/20001/lib/build/initializer_pl...
File lib/build/initializer_plugin.dart (right):

https://codereview.chromium.org/951463004/diff/20001/lib/build/initializer_pl...
lib/build/initializer_plugin.dart:272: if (value is String) value =
_stringValue(value);
On 2015/02/25 21:06:33, Siggi Cherem (dart-lang) wrote:
> On 2015/02/25 20:23:05, jakemac wrote:
> > On 2015/02/25 19:32:08, Siggi Cherem (dart-lang) wrote:
> > > we might need to check for instance creations here as well. 
> > > 
> > > For example, I'm not sure if we handle this correctly:
> > > 
> > > a.dart:
> > >   @HtmlImport(b.foo);
> > >   library a;
> > > 
> > >   import 'b.dart' as b;
> > > 
> > > b.dart:
> > >   const foo = const Foo()
> > >   
> > > 
> > > This will get normalized to the value `const Foo()` here, I believe
> > 
> > Above this there is a special case for Identifiers, they aren't evaluated
but
> > just left alone (and prefixed). The `constructor arguments` test has an
> example
> > of this.
> > 
> > This code path is just for expressions that aren't simple literals,
> identifiers,
> > or constructors.
> 
> but is there any case where those could evaluate to a constructor as a result?

Done.

[jakemac, 2015-02-25 22:08:12]

Committed patchset #3 (id:40001) manually as
e852273435659d36dd9e9a231af7afb5e47a1e5c (presubmit successful).