Issue 951423002: Add more performance tags.

Issue 951423002: Add more performance tags. (Closed)

Created:
5 years, 10 months ago by scheglov

Modified:
5 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add more performance tags. This reduces amount of "unknown" time to less than 1%. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44000

Patch Set 1 #

Total comments: 2

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+173 lines, -132 lines)			Patch
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/StdioServerSocket.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/analysis_server.dart	View	2 chunks	+36 lines, -20 lines	0 comments	Download
M	pkg/analysis_server/lib/src/channel/byte_stream_channel.dart	View	4 chunks	+34 lines, -20 lines	2 comments	Download
M	pkg/analysis_server/lib/src/channel/channel.dart	View	2 chunks	+0 lines, -13 lines	0 comments	Download
M	pkg/analysis_server/lib/src/channel/web_socket_channel.dart	View	3 chunks	+31 lines, -17 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/engine.dart	View	2 chunks	+71 lines, -62 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/951423002/diff/1/pkg/analysis_server/lib/src/channel/byte_stream_channel.dart File pkg/analysis_server/lib/src/channel/byte_stream_channel.dart (right): https://codereview.chromium.org/951423002/diff/1/pkg/analysis_server/lib/src/channel/byte_stream_channel.dart#newcode133 pkg/analysis_server/lib/src/channel/byte_stream_channel.dart:133: } There's a lot of boiler-plate here. How ...

5 years, 10 months ago (2015-02-24 20:07:29 UTC) #2

scheglov

Committed patchset #1 (id:1) manually as 44000 (presubmit successful).

5 years, 10 months ago (2015-02-24 21:48:11 UTC) #3

scheglov

5 years, 10 months ago (2015-02-24 21:49:04 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/951423002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/channel/byte_stream_channel.dart (right):

https://codereview.chromium.org/951423002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/channel/byte_stream_channel.dart:133: }
Will do in a separate CL.

Expand Messages | Collapse Messages