Issue 95123002: Substitute type variables as type arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 95123002: Substitute type variables as type arguments. (Closed)

Created:
7 years ago by zarah

Modified:
7 years ago

Reviewers:
Johnni Winther, ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Substitute type variables as type arguments. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=30769

Patch Set 1 : #

Total comments: 2

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -34 lines)			Patch
M	sdk/lib/_internal/lib/js_mirrors.dart	View	5 chunks	+23 lines, -6 lines	2 comments	Download
M	tests/lib/lib.status	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	tests/lib/mirrors/equality_test.dart	View	4 chunks	+22 lines, -20 lines	0 comments	Download
M	tests/lib/mirrors/generics_substitution_test.dart	View	1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ahe

DBC https://codereview.chromium.org/95123002/diff/20001/sdk/lib/_internal/lib/js_mirrors.dart File sdk/lib/_internal/lib/js_mirrors.dart (right): https://codereview.chromium.org/95123002/diff/20001/sdk/lib/_internal/lib/js_mirrors.dart#newcode1978 sdk/lib/_internal/lib/js_mirrors.dart:1978: if (type is int) { type is num

7 years ago (2013-11-28 14:45:49 UTC) #3

zarah

https://codereview.chromium.org/95123002/diff/20001/sdk/lib/_internal/lib/js_mirrors.dart File sdk/lib/_internal/lib/js_mirrors.dart (right): https://codereview.chromium.org/95123002/diff/20001/sdk/lib/_internal/lib/js_mirrors.dart#newcode1978 sdk/lib/_internal/lib/js_mirrors.dart:1978: if (type is int) { On 2013/11/28 14:45:49, ahe ...

7 years ago (2013-11-29 08:43:59 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r30769 (presubmit successful).

Expand Messages | Collapse Messages