Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 950883003: fix bug in scriptcompactors bootstrap and added transform function which can be used by other trans… (Closed)

Created:
5 years, 10 months ago by jakemac
Modified:
5 years, 10 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/web-components.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix bug in scriptcompactors bootstrap and added transform function which can be used by other transformers R=sigmund@google.com Committed: https://github.com/dart-lang/core-elements/commit/e7abc74478fe619a129610157342634e04e0ee09

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -24 lines) Patch
M CHANGELOG.md View 1 chunk +8 lines, -0 lines 0 comments Download
M lib/build/script_compactor.dart View 1 chunk +1 line, -1 line 2 comments Download
M lib/build/web_components.dart View 2 chunks +30 lines, -15 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/build/script_compactor_test.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M test/build/transformer_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
jakemac
5 years, 10 months ago (2015-02-23 16:37:43 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/950883003/diff/1/lib/build/script_compactor.dart File lib/build/script_compactor.dart (right): https://codereview.chromium.org/950883003/diff/1/lib/build/script_compactor.dart#newcode122 lib/build/script_compactor.dart:122: buffer.writeln('void main() { i$i.main(); }'); since this is ...
5 years, 10 months ago (2015-02-23 18:15:17 UTC) #3
jakemac
https://codereview.chromium.org/950883003/diff/1/lib/build/script_compactor.dart File lib/build/script_compactor.dart (right): https://codereview.chromium.org/950883003/diff/1/lib/build/script_compactor.dart#newcode122 lib/build/script_compactor.dart:122: buffer.writeln('void main() { i$i.main(); }'); On 2015/02/23 18:15:16, Siggi ...
5 years, 10 months ago (2015-02-23 18:19:16 UTC) #4
jakemac
5 years, 10 months ago (2015-02-23 18:20:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e7abc74478fe619a129610157342634e04e0ee09 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698