Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 950733002: Int64 tweaks for better type infererence (Closed)

Created:
5 years, 10 months ago by sra1
Modified:
5 years, 10 months ago
Reviewers:
herhut
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Int64 tweaks for better type infererence In some programs Int64._l was inferred as possibly null. BUG= R=herhut@google.com Committed: https://code.google.com/p/dart/source/detail?r=43998

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M pkg/fixnum/lib/src/int64.dart View 5 chunks +7 lines, -10 lines 0 comments Download
M pkg/fixnum/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
sra1
I'm not sure why Int64._l was inferred as [null|subtype=int] Int64.toInt() was also inferred as [null|subtype=int]. ...
5 years, 10 months ago (2015-02-23 00:43:39 UTC) #2
sra1
ping
5 years, 10 months ago (2015-02-24 04:16:53 UTC) #3
herhut
On 2015/02/24 04:16:53, sra1 wrote: > ping Did you try this before or after https://codereview.chromium.org/941293002/ ...
5 years, 10 months ago (2015-02-24 19:04:59 UTC) #4
sra1
5 years, 10 months ago (2015-02-24 20:52:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43998 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698