Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 950613003: Fix issue 22525 (Closed)

Created:
5 years, 10 months ago by Brian Wilkerson
Modified:
5 years, 10 months ago
Reviewers:
Leaf, scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+843 lines, -748 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 7 chunks +34 lines, -15 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 45 chunks +809 lines, -733 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
Sorry about the churn in the test class. It looks like it hadn't been sorted ...
5 years, 10 months ago (2015-02-21 15:53:38 UTC) #2
scheglov
LGTM
5 years, 10 months ago (2015-02-21 18:08:17 UTC) #3
Brian Wilkerson
Committed patchset #1 (id:1) manually as 43960 (presubmit successful).
5 years, 10 months ago (2015-02-23 16:16:57 UTC) #4
Leaf
5 years, 10 months ago (2015-02-23 16:42:03 UTC) #5
Message was sent while issue was closed.
lgtm,thanks!

Powered by Google App Engine
This is Rietveld 408576698