Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 950483002: Switch dartfmt in the SDK to run dart_style. (Closed)

Created:
5 years, 10 months ago by Bob Nystrom
Modified:
5 years, 9 months ago
Reviewers:
ricow1, dgrove, pquitslund
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Switch dartfmt in the SDK to run dart_style. BUG=https://code.google.com/p/dart/issues/detail?id=22400 R=pquitslund@google.com, ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=44108

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix copy/paste error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -59 lines) Patch
M sdk/bin/dartfmt View 1 2 chunks +20 lines, -29 lines 0 comments Download
M sdk/bin/dartfmt.bat View 1 chunk +26 lines, -9 lines 0 comments Download
A + sdk/bin/dartfmt_sdk View 1 2 chunks +5 lines, -7 lines 0 comments Download
A + sdk/bin/dartfmt_sdk.bat View 2 chunks +3 lines, -11 lines 0 comments Download
M tools/create_sdk.py View 1 chunk +1 line, -1 line 0 comments Download
M utils/dartfmt/dartfmt.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bob Nystrom
This CL: - Makes the dartfmt snapshot in the SDK come from dart_style instead of ...
5 years, 10 months ago (2015-02-20 23:09:55 UTC) #2
pquitslund
lgtm
5 years, 10 months ago (2015-02-21 00:18:19 UTC) #3
ricow1
lgtm https://codereview.chromium.org/950483002/diff/1/sdk/bin/dartfmt File sdk/bin/dartfmt (right): https://codereview.chromium.org/950483002/diff/1/sdk/bin/dartfmt#newcode6 sdk/bin/dartfmt:6: # Run dartanalyzer.dart on the Dart VM. This ...
5 years, 10 months ago (2015-02-23 08:10:49 UTC) #5
Bob Nystrom
https://codereview.chromium.org/950483002/diff/1/sdk/bin/dartfmt File sdk/bin/dartfmt (right): https://codereview.chromium.org/950483002/diff/1/sdk/bin/dartfmt#newcode6 sdk/bin/dartfmt:6: # Run dartanalyzer.dart on the Dart VM. This script ...
5 years, 9 months ago (2015-02-27 22:56:47 UTC) #6
Bob Nystrom
5 years, 9 months ago (2015-02-27 23:00:52 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 44108 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698