Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 950463002: Added a test for issue 22523. (Closed)

Created:
5 years, 10 months ago by srdjan
Modified:
5 years, 10 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
A tests/language/async_rethrow_test.dart View 1 1 chunk +44 lines, -0 lines 0 comments Download
M tests/language/language.status View 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
srdjan
5 years, 10 months ago (2015-02-20 22:05:43 UTC) #2
hausner
LGTM. You could strengthen the test by checking whether the onError handlers actually get executed.
5 years, 10 months ago (2015-02-20 22:38:17 UTC) #3
srdjan
On 2015/02/20 22:38:17, hausner wrote: > LGTM. > > You could strengthen the test by ...
5 years, 10 months ago (2015-02-20 22:49:33 UTC) #4
srdjan
5 years, 10 months ago (2015-02-20 22:55:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r43935 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698