Share the JavaScript based LinkedHashMap implementation between constant maps and the LinkedHashMap…

Share the JavaScript based LinkedHashMap implementation between constant maps and the LinkedHashMap patch.

This fixes performance a performance issue with using enums, because their backing map required runtime type information before (due to a lack of precision on the analysis of factory constructors).

R=johnniwinther@google.com

bug= dartbug.com/22495

Committed: https://code.google.com/p/dart/source/detail?r=43984

[Johnni Winther, 2015-02-24 10:14:16]

lgtm

[karlklose, 2015-02-24 11:13:11]

Committed patchset #1 (id:1) manually as 43984 (presubmit successful).

[sra1, 2015-02-24 16:51:37]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2015-02-24 16:51:37]

Any ideas why this increases the size of swarm by 2k?
I would have though that sharing code would be smaller.

[karlklose, 2015-02-25 07:41:02]

On 2015/02/24 16:51:37, sra1 wrote:
> Any ideas why this increases the size of swarm by 2k?
> I would have though that sharing code would be smaller.

Maybe because I made some fields public that were private before and they clash
with names in swarm, which may confuse type inference. I'll take a look.
Meanwhile, I already have a CL to rename these fields at
https://codereview.chromium.org/947373003/ to fix a regression when reapplying
Stephan's original CL https://codereview.chromium.org/929313002/.

This CL introduces the need for sharing, because it changes the constant map
implementation to use the internal hash map implementation that was previously
only used by the LinkedHashMap patch.

[sra1, 2015-05-15 22:59:34]

https://codereview.chromium.org/949733003/diff/1/sdk/lib/_internal/compiler/j...
File sdk/lib/_internal/compiler/js_lib/collection_patch.dart (right):

https://codereview.chromium.org/949733003/diff/1/sdk/lib/_internal/compiler/j...
sdk/lib/_internal/compiler/js_lib/collection_patch.dart:542: int
internalFindBucketIndex(var bucket, var key) {
Can this be rewritten to avoid public names that are not part of an interface?

[Johnni Winther, 2015-05-18 07:11:31]

https://codereview.chromium.org/949733003/diff/1/sdk/lib/_internal/compiler/j...
File sdk/lib/_internal/compiler/js_lib/collection_patch.dart (right):

https://codereview.chromium.org/949733003/diff/1/sdk/lib/_internal/compiler/j...
sdk/lib/_internal/compiler/js_lib/collection_patch.dart:542: int
internalFindBucketIndex(var bucket, var key) {
On 2015/05/15 22:59:33, sra1 wrote:
> Can this be rewritten to avoid public names that are not part of an interface?

If not, maybe we should make named of injected members implicitly private within
the internal libraries.