Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 949623005: Field references in field format parameter declarations and initializers mean writing. (Closed)

Created:
5 years, 10 months ago by scheglov
Modified:
5 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Field references in field format parameter declarations and initializers mean writing. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43971

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -46 lines) Patch
M pkg/analysis_server/lib/src/services/index/index_contributor.dart View 2 chunks +21 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/search/search_engine_internal.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/search/element_references_test.dart View 3 chunks +5 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/index/dart_index_contributor_test.dart View 2 chunks +51 lines, -41 lines 0 comments Download
M pkg/analysis_server/test/services/search/search_engine_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 10 months ago (2015-02-23 18:37:53 UTC) #1
Brian Wilkerson
LGTM
5 years, 10 months ago (2015-02-23 18:43:59 UTC) #2
scheglov
5 years, 10 months ago (2015-02-23 18:45:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43971 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698