Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 948933004: Re-enable printing and timers in Dartium isolates (Closed)

Created:
5 years, 10 months ago by Alan Knight
Modified:
5 years, 9 months ago
Reviewers:
vsm, terry
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Re-enable printing and timers in Dartium isolates BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=44050

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review fixes #

Patch Set 3 : rename spawnDomFunction to spawnDomHelper #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -21 lines) Patch
M sdk/lib/_blink/dartium/_blink_dartium.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 8 chunks +120 lines, -9 lines 0 comments Download
M tests/html/html.status View 2 chunks +1 line, -3 lines 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 1 2 8 chunks +120 lines, -9 lines 1 comment Download

Messages

Total messages: 9 (2 generated)
Alan Knight
Reverts https://codereview.chromium.org//25536007 and updates it to current code
5 years, 10 months ago (2015-02-24 01:30:06 UTC) #2
vsm
lgtm https://codereview.chromium.org/948933004/diff/1/tools/dom/src/native_DOMImplementation.dart File tools/dom/src/native_DOMImplementation.dart (right): https://codereview.chromium.org/948933004/diff/1/tools/dom/src/native_DOMImplementation.dart#newcode903 tools/dom/src/native_DOMImplementation.dart:903: // special DOM isolate. Perhaps update this comment ...
5 years, 9 months ago (2015-02-24 20:24:19 UTC) #3
vsm
https://codereview.chromium.org/948933004/diff/1/tools/dom/src/native_DOMImplementation.dart File tools/dom/src/native_DOMImplementation.dart (right): https://codereview.chromium.org/948933004/diff/1/tools/dom/src/native_DOMImplementation.dart#newcode193 tools/dom/src/native_DOMImplementation.dart:193: native "Utils_spawnDomFunction"; Actually, we've moved all native methods to ...
5 years, 9 months ago (2015-02-24 20:29:02 UTC) #4
Alan Knight
https://codereview.chromium.org/948933004/diff/1/tools/dom/src/native_DOMImplementation.dart File tools/dom/src/native_DOMImplementation.dart (right): https://codereview.chromium.org/948933004/diff/1/tools/dom/src/native_DOMImplementation.dart#newcode193 tools/dom/src/native_DOMImplementation.dart:193: native "Utils_spawnDomFunction"; On 2015/02/24 20:29:02, vsm wrote: > Actually, ...
5 years, 9 months ago (2015-02-26 15:52:19 UTC) #5
vsm
lgtm
5 years, 9 months ago (2015-02-26 15:54:44 UTC) #6
Alan Knight
Committed patchset #3 (id:40001) manually as 44050 (presubmit successful).
5 years, 9 months ago (2015-02-26 15:55:38 UTC) #7
terry
5 years, 9 months ago (2015-02-26 16:53:07 UTC) #9
Message was sent while issue was closed. 
https://codereview.chromium.org/948933004/diff/40001/tools/dom/src/native_DOM...
File tools/dom/src/native_DOMImplementation.dart (right):

https://codereview.chromium.org/948933004/diff/40001/tools/dom/src/native_DOM...
tools/dom/src/native_DOMImplementation.dart:193:
_blink.Blink_Utils.spawnDomHelper(f, replyTo);
Alan shouldn't this be:

static void spawnDomHelper(Function f, int replyTo) =>
    _blink.Blink_Utils.spawnDomHelper(f, replyTo);

Powered by Google App Engine
This is Rietveld 408576698