Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 94873002: Fix ContainerTypeMask== and ContainerTypeMask.hashCode. (Closed)

Created:
7 years ago by ngeoffray
Modified:
7 years ago
Reviewers:
lukas
CC:
reviews_dartlang.org, kasperl
Visibility:
Public.

Description

Fix ContainerTypeMask== and ContainerTypeMask.hashCode. R=lry@google.com Committed: https://code.google.com/p/dart/source/detail?r=30760

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -5 lines) Patch
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/container_type_mask.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/util/util.dart View 1 chunk +3 lines, -2 lines 0 comments Download
A tests/compiler/dart2js/container_mask_equal_test.dart View 1 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ngeoffray
7 years ago (2013-11-28 12:30:11 UTC) #1
lukas
LGTM, thanks for fixing my CL :) https://codereview.chromium.org/94873002/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): https://codereview.chromium.org/94873002/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#newcode3963 sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3963: newInstance.instructionType = ...
7 years ago (2013-11-28 13:06:23 UTC) #2
ngeoffray
Thanks Lukas. https://codereview.chromium.org/94873002/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): https://codereview.chromium.org/94873002/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#newcode3963 sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3963: newInstance.instructionType = elementType; On 2013/11/28 13:06:23, lukas ...
7 years ago (2013-11-28 13:08:57 UTC) #3
ngeoffray
7 years ago (2013-11-28 13:10:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r30760 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698