Unify dart:async and pub/io.dart TimeoutException classes.

Unify dart:async and pub/io.dart TimeoutException classes.

R=floitsch@google.com, nweiz@google.com, rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30809

[Lasse Reichstein Nielsen, 2013-11-28 12:21:06]

Any objections to unifying the pub TimeoutException with the new one in
dart:async?

I've changed the constructor signature to be compatible with the pub type. The
message will be different (by prefixing with "TimeoutException:"), and I added
the duration to the pub call as well, but I can remove that again if you don't
want it.

[floitsch, 2013-11-28 13:11:41]

LGTM.
Please, wait for Bob and Nathan before committing.

[Lasse Reichstein Nielsen, 2013-12-02 08:46:33]

ping Bob, Nathan?

[Bob Nystrom, 2013-12-02 22:40:42]

No objections from me. One request then LGTM!

https://codereview.chromium.org/94843002/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/io.dart (right):

https://codereview.chromium.org/94843002/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/io.dart:9: export 'dart:async' show
TimeoutException;
Let's remove this and just change any other files that need to this import
dart:async if they aren't already.

[nweiz, 2013-12-02 23:54:21]

lgtm

https://codereview.chromium.org/94843002/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/io.dart (right):

https://codereview.chromium.org/94843002/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/io.dart:633: Future timeout(Future input, int
milliseconds, String description) {
Add a TODO assigned to me to replace this with [Future.timeout].

[Lasse Reichstein Nielsen, 2013-12-03 08:38:14]

Committed patchset #2 manually as r30809 (presubmit successful).

[Lasse Reichstein Nielsen, 2013-12-03 08:38:28]

https://codereview.chromium.org/94843002/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/io.dart (right):

https://codereview.chromium.org/94843002/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/io.dart:9: export 'dart:async' show
TimeoutException;
Removed.
I don't think it's needed anywhere, but I didn't want to change the public
signature of the library because I don't know where it is used. It's probably
only internal use, so it should be fine.

https://codereview.chromium.org/94843002/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/io.dart:633: Future timeout(Future input, int
milliseconds, String description) {
On 2013/12/02 23:54:22, nweiz wrote:
> Add a TODO assigned to me to replace this with [Future.timeout].

Done.