Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 948353002: Initialize "next" variable in async rewrite whenever there is a finally. (Closed)

Created:
5 years, 10 months ago by zarah
Modified:
5 years, 10 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org, floitsch
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Initialize "next" variable in async rewrite whenever there is a finally. R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=43983

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M pkg/compiler/lib/src/js/rewrite_async.dart View 1 5 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
zarah
5 years, 10 months ago (2015-02-24 09:39:25 UTC) #2
sigurdm
Besides the comment LGTM https://codereview.chromium.org/948353002/diff/1/pkg/compiler/lib/src/js/rewrite_async.dart File pkg/compiler/lib/src/js/rewrite_async.dart (right): https://codereview.chromium.org/948353002/diff/1/pkg/compiler/lib/src/js/rewrite_async.dart#newcode845 pkg/compiler/lib/src/js/rewrite_async.dart:845: if (analysis.hasFinally) { Should be ...
5 years, 10 months ago (2015-02-24 10:06:49 UTC) #3
zarah
https://codereview.chromium.org/948353002/diff/1/pkg/compiler/lib/src/js/rewrite_async.dart File pkg/compiler/lib/src/js/rewrite_async.dart (right): https://codereview.chromium.org/948353002/diff/1/pkg/compiler/lib/src/js/rewrite_async.dart#newcode845 pkg/compiler/lib/src/js/rewrite_async.dart:845: if (analysis.hasFinally) { On 2015/02/24 10:06:49, sigurdm wrote: > ...
5 years, 10 months ago (2015-02-24 10:28:44 UTC) #4
zarah
5 years, 10 months ago (2015-02-24 10:42:59 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 43983 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698