Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 948113003: Add a --simple flag to status_reporter to allow a fast build covering important configurations (Closed)

Created:
5 years, 10 months ago by kevmoo
Modified:
5 years, 9 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a --simple flag to status_reporter to allow a fast build covering important configurations R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=44087

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -8 lines) Patch
M tools/testing/dart/status_reporter.dart View 2 chunks +31 lines, -8 lines 5 comments Download

Messages

Total messages: 7 (1 generated)
kevmoo
5 years, 10 months ago (2015-02-23 20:39:10 UTC) #2
ricow1
lgtm https://codereview.chromium.org/948113003/diff/1/tools/testing/dart/status_reporter.dart File tools/testing/dart/status_reporter.dart (right): https://codereview.chromium.org/948113003/diff/1/tools/testing/dart/status_reporter.dart#newcode161 tools/testing/dart/status_reporter.dart:161: for (var mode in combination['modes']) { why not ...
5 years, 9 months ago (2015-02-27 10:34:56 UTC) #3
kevmoo
Committed patchset #1 (id:1) manually as 44087 (presubmit successful).
5 years, 9 months ago (2015-02-27 12:08:47 UTC) #4
kevmoo
https://codereview.chromium.org/948113003/diff/1/tools/testing/dart/status_reporter.dart File tools/testing/dart/status_reporter.dart (right): https://codereview.chromium.org/948113003/diff/1/tools/testing/dart/status_reporter.dart#newcode161 tools/testing/dart/status_reporter.dart:161: for (var mode in combination['modes']) { On 2015/02/27 10:34:56, ...
5 years, 9 months ago (2015-02-27 12:11:23 UTC) #5
ricow1
https://codereview.chromium.org/948113003/diff/1/tools/testing/dart/status_reporter.dart File tools/testing/dart/status_reporter.dart (right): https://codereview.chromium.org/948113003/diff/1/tools/testing/dart/status_reporter.dart#newcode163 tools/testing/dart/status_reporter.dart:163: break; don't you mean continue? I assume this just ...
5 years, 9 months ago (2015-03-02 07:43:42 UTC) #6
kevmoo
5 years, 9 months ago (2015-03-03 17:36:36 UTC) #7
Message was sent while issue was closed. 
On 2015/03/02 07:43:42, ricow1 wrote:
>
https://codereview.chromium.org/948113003/diff/1/tools/testing/dart/status_re...
> File tools/testing/dart/status_reporter.dart (right):
> 
>
https://codereview.chromium.org/948113003/diff/1/tools/testing/dart/status_re...
> tools/testing/dart/status_reporter.dart:163: break;
> don't you mean continue? I assume this just works because release is before
> debug in out combinations lists
> 
> Same below for arches

See https://codereview.chromium.org/974973002/ for fix

Powered by Google App Engine
This is Rietveld 408576698