Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 946803002: Create package: URIs everywhere (Closed)

Created:
5 years, 10 months ago by Brian Wilkerson
Modified:
5 years, 10 months ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -130 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 5 chunks +46 lines, -28 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 9 chunks +38 lines, -61 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 8 chunks +42 lines, -36 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 2 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
I'm not particularly happy with the way this fix is coded, so suggestions for improvements ...
5 years, 10 months ago (2015-02-21 21:31:07 UTC) #2
scheglov
LGTM
5 years, 10 months ago (2015-02-23 16:04:42 UTC) #3
Paul Berry
lgtm
5 years, 10 months ago (2015-02-23 17:27:27 UTC) #4
Brian Wilkerson
5 years, 10 months ago (2015-02-23 17:35:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43965 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698