Use more js templates in async rewrite.

Use more js templates in async rewrite.

Also switch some js '==' to '==='.

BUG=
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43986

[sigurdm, 2015-02-23 14:59:33]

sigurdm@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2015-02-23 16:15:35]

LGTM.

https://codereview.chromium.org/946353003/diff/1/pkg/compiler/lib/src/js/rewr...
File pkg/compiler/lib/src/js/rewrite_async.dart (right):

https://codereview.chromium.org/946353003/diff/1/pkg/compiler/lib/src/js/rewr...
pkg/compiler/lib/src/js/rewrite_async.dart:509: addStatement(js.js.statement('#
= #;', [tempVar, result]));
apparently you don't need the ";". (At least you don't have it in line 408.
Either add it there too, or remove it here.

https://codereview.chromium.org/946353003/diff/1/pkg/compiler/lib/src/js/rewr...
pkg/compiler/lib/src/js/rewrite_async.dart:1031: : js.js.statement('# = #',
[resultName, left]);
ditto.

https://codereview.chromium.org/946353003/diff/1/pkg/compiler/lib/src/js/rewr...
pkg/compiler/lib/src/js/rewrite_async.dart:1033:
addStatement(js.js.statement('if (#) {#} else #',
you don't need the "{}" around the 'then' block.

https://codereview.chromium.org/946353003/diff/1/pkg/compiler/lib/src/js/rewr...
pkg/compiler/lib/src/js/rewrite_async.dart:1037:
addStatement(js.js.statement('if (#) {#} else #',
ditto

https://codereview.chromium.org/946353003/diff/1/pkg/compiler/lib/src/js/rewr...
pkg/compiler/lib/src/js/rewrite_async.dart:1045: addStatement(js.js.statement('#
= #', [resultName, value]));
";" or not. (depending on above).

https://codereview.chromium.org/946353003/diff/1/pkg/compiler/lib/src/js/rewr...
pkg/compiler/lib/src/js/rewrite_async.dart:1192:
addStatement(js.js.statement('do {#} while #', [node.body, condition]));
no need for "{ }".

[sigurdm, 2015-02-24 13:16:20]

https://codereview.chromium.org/946353003/diff/1/pkg/compiler/lib/src/js/rewr...
File pkg/compiler/lib/src/js/rewrite_async.dart (right):

https://codereview.chromium.org/946353003/diff/1/pkg/compiler/lib/src/js/rewr...
pkg/compiler/lib/src/js/rewrite_async.dart:509: addStatement(js.js.statement('#
= #;', [tempVar, result]));
On 2015/02/23 16:15:34, floitsch wrote:
> apparently you don't need the ";". (At least you don't have it in line 408.
> Either add it there too, or remove it here.

I'll add it everywhere

https://codereview.chromium.org/946353003/diff/1/pkg/compiler/lib/src/js/rewr...
pkg/compiler/lib/src/js/rewrite_async.dart:1031: : js.js.statement('# = #',
[resultName, left]);
On 2015/02/23 16:15:34, floitsch wrote:
> ditto.

Acknowledged.

https://codereview.chromium.org/946353003/diff/1/pkg/compiler/lib/src/js/rewr...
pkg/compiler/lib/src/js/rewrite_async.dart:1033:
addStatement(js.js.statement('if (#) {#} else #',
On 2015/02/23 16:15:34, floitsch wrote:
> you don't need the "{}" around the 'then' block.

Yes, otherwise the js parser sees # else as a hole named #else

https://codereview.chromium.org/946353003/diff/1/pkg/compiler/lib/src/js/rewr...
pkg/compiler/lib/src/js/rewrite_async.dart:1037:
addStatement(js.js.statement('if (#) {#} else #',
On 2015/02/23 16:15:34, floitsch wrote:
> ditto

Acknowledged.

https://codereview.chromium.org/946353003/diff/1/pkg/compiler/lib/src/js/rewr...
pkg/compiler/lib/src/js/rewrite_async.dart:1045: addStatement(js.js.statement('#
= #', [resultName, value]));
On 2015/02/23 16:15:34, floitsch wrote:
> ";" or not. (depending on above).

Done.

https://codereview.chromium.org/946353003/diff/1/pkg/compiler/lib/src/js/rewr...
pkg/compiler/lib/src/js/rewrite_async.dart:1192:
addStatement(js.js.statement('do {#} while #', [node.body, condition]));
On 2015/02/23 16:15:34, floitsch wrote:
> no need for "{ }".

Ditto

[sigurdm, 2015-02-24 13:30:16]

Committed patchset #2 (id:20001) manually as 43986 (presubmit successful).