Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 94593002: Hide more TimeoutExceptions in all the files importing pub's io.dart. (Closed)

Created:
7 years ago by Lasse Reichstein Nielsen
Modified:
7 years ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, nweiz, Bob Nystrom
Visibility:
Public.

Description

Hide more TimeoutExceptions in all the files importing pub's io.dart. Committed: https://code.google.com/p/dart/source/detail?r=30758

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -31 lines) Patch
M sdk/lib/_internal/pub/bin/pub.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/sources.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/build.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/cache.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/help.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/lish.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/list_package_dirs.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/serve.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/uploader.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/entrypoint.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/git.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/http.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/log.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/oauth2.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/source.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/source/git.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/source/hosted.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/source/path.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/system_cache.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/compiled_dartdoc.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/directory.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/lib.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/license.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/name.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/utf8_readme.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/descriptor/tar.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/io_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/test_pub.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
7 years ago (2013-11-28 10:35:15 UTC) #1
Lasse Reichstein Nielsen
TBR, to keep the analyzer happy.
7 years ago (2013-11-28 10:35:30 UTC) #2
Lasse Reichstein Nielsen
Committed patchset #1 manually as r30758 (presubmit successful).
7 years ago (2013-11-28 10:36:11 UTC) #3
floitsch
7 years ago (2013-11-28 12:01:57 UTC) #4
Message was sent while issue was closed. 
LGTM, but I would prefer if we unified async's TimeoutException and the one in
pub.

Powered by Google App Engine
This is Rietveld 408576698