Improve the documentation for exit codes in Process

Improve the documentation for exit codes in Process

R=ahe@google.com, ajohnsen@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=30778

[Søren Gjesse, 2013-11-28 10:22:39]

Peter, for now I have just put in a recommendation to stay in the [0..127]
range.

[kustermann, 2013-11-28 10:25:54]

Thanks for clarifying this in the documentation :)

[ahe, 2013-11-28 14:27:23]

https://codereview.chromium.org/94573002/diff/40001/sdk/lib/io/process.dart
File sdk/lib/io/process.dart (right):

https://codereview.chromium.org/94573002/diff/40001/sdk/lib/io/process.dart#n...
sdk/lib/io/process.dart:17: * Exit the Dart VM process immediately with the
given [exitCode] exit
I think it is problematic to use the word exitCode here as it shadows the setter
below.

https://codereview.chromium.org/94573002/diff/40001/sdk/lib/io/process.dart#n...
sdk/lib/io/process.dart:61: set exitCode(int exitCode) {
Even more troubling here :-)

https://codereview.chromium.org/94573002/diff/40001/sdk/lib/io/process.dart#n...
sdk/lib/io/process.dart:239: * the exit code will be a negative value in the
range [-255..0],
Does 0 mean that it crashed or not?

https://codereview.chromium.org/94573002/diff/40001/sdk/lib/io/process.dart#n...
sdk/lib/io/process.dart:252: * 0xffffffff`.
I would argue that the VM should perform this computation and not return a
negative number.

[Søren Gjesse, 2013-11-29 10:29:24]

https://codereview.chromium.org/94573002/diff/40001/sdk/lib/io/process.dart
File sdk/lib/io/process.dart (right):

https://codereview.chromium.org/94573002/diff/40001/sdk/lib/io/process.dart#n...
sdk/lib/io/process.dart:17: * Exit the Dart VM process immediately with the
given [exitCode] exit
On 2013/11/28 14:27:23, ahe wrote:
> I think it is problematic to use the word exitCode here as it shadows the
setter
> below.

Renamed argument to code..

https://codereview.chromium.org/94573002/diff/40001/sdk/lib/io/process.dart#n...
sdk/lib/io/process.dart:61: set exitCode(int exitCode) {
On 2013/11/28 14:27:23, ahe wrote:
> Even more troubling here :-)

Renamed to code here as well.

https://codereview.chromium.org/94573002/diff/40001/sdk/lib/io/process.dart#n...
sdk/lib/io/process.dart:239: * the exit code will be a negative value in the
range [-255..0],
On 2013/11/28 14:27:23, ahe wrote:
> Does 0 mean that it crashed or not?

0 should not have been in the range. Changed to [-255..0[.

https://codereview.chromium.org/94573002/diff/40001/sdk/lib/io/process.dart#n...
sdk/lib/io/process.dart:252: * 0xffffffff`.
On 2013/11/28 14:27:23, ahe wrote:
> I would argue that the VM should perform this computation and not return a
> negative number.

I did make the change https://codereview.chromium.org/85393002/ to actually do
this, but I also like the fact that you can check for negative exit codes cross
platform and get the "fatal" exit codes. We will keep it like this.

[ahe, 2013-11-29 10:43:19]

LGTM, but I still think it is problematic to use negative values on Windows.

https://codereview.chromium.org/94573002/diff/60001/sdk/lib/io/process.dart
File sdk/lib/io/process.dart (right):

https://codereview.chromium.org/94573002/diff/60001/sdk/lib/io/process.dart#n...
sdk/lib/io/process.dart:240: * number. E.g. if a process crashes due to a
segmentation violation
Tech writers have told me to avoid "e.g." and "i.e." as it is confusing to
people that aren't fluent in English.

Instead of "e.g.", use "for example".

Instead of "i.e.", use "that is".

Also, "e.g.", "for example", "i.e.", and "that is" should always be followed by
a comma.

[Anders Johnsen, 2013-11-29 11:18:12]

lgtm

https://codereview.chromium.org/94573002/diff/80001/sdk/lib/io/process.dart
File sdk/lib/io/process.dart (right):

https://codereview.chromium.org/94573002/diff/80001/sdk/lib/io/process.dart#n...
sdk/lib/io/process.dart:28: * result in a actual exit code of 255 being
reported.
an actual

[Søren Gjesse, 2013-11-29 11:19:31]

https://codereview.chromium.org/94573002/diff/80001/sdk/lib/io/process.dart
File sdk/lib/io/process.dart (right):

https://codereview.chromium.org/94573002/diff/80001/sdk/lib/io/process.dart#n...
sdk/lib/io/process.dart:28: * result in a actual exit code of 255 being
reported.
On 2013/11/29 11:18:12, Anders Johnsen wrote:
> an actual

Done.

[Søren Gjesse, 2013-11-29 11:20:24]

Committed patchset #6 manually as r30778 (presubmit successful).