Issue 944813002: Make enum a keyword in dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 944813002: Make enum a keyword in dart2js. (Closed)

Created:
5 years, 10 months ago by Johnni Winther

Modified:
5 years, 10 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, sethladd, gbracha

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Make enum a keyword in dart2js. BUG=http://dartbug.com/22478 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=43906

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	pkg/compiler/lib/src/scanner/keyword.dart	View		2 chunks	+1 line, -1 line	0 comments	Download
	A +	tests/language/enum_is_keyword_test.dart	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

floitsch

LGTM. Please make sure that this change is communicated in the 1.9 announcement.

5 years, 10 months ago (2015-02-20 10:42:01 UTC) #3

Johnni Winther

5 years, 10 months ago (2015-02-20 10:55:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 43906 (presubmit successful).