Issue 944783002: Save top StackResource in entry frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 944783002: Save top StackResource in entry frame. (Closed)

Created:
5 years, 10 months ago by koda

Modified:
5 years, 10 months ago

Reviewers:
zra, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Save top StackResource in entry frame. This avoids relying on stack address order, which enables us to benefit from AddressSanitizer's detect_stack_use_after_return feature. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=43927

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -74 lines)			Patch
M	runtime/vm/allocation.h	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/allocation.cc	View	1 2	1 chunk	+1 line, -17 lines	0 comments	Download
M	runtime/vm/base_isolate.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/exceptions.cc	View	1 2	1 chunk	+1 line, -4 lines	0 comments	Download
M	runtime/vm/longjump.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/simulator_arm.cc	View	1 2	3 chunks	+1 line, -5 lines	0 comments	Download
M	runtime/vm/simulator_arm64.cc	View	1 2	3 chunks	+1 line, -5 lines	0 comments	Download
M	runtime/vm/simulator_mips.cc	View	1 2	3 chunks	+1 line, -5 lines	0 comments	Download
M	runtime/vm/stack_frame_arm.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/stack_frame_arm64.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/stack_frame_ia32.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/stack_frame_mips.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/stack_frame_x64.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	1	2 chunks	+9 lines, -5 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View	1	2 chunks	+9 lines, -5 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1	2 chunks	+8 lines, -3 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View	1	3 chunks	+14 lines, -10 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1	3 chunks	+9 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

koda

5 years, 10 months ago (2015-02-20 20:46:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as r43927 (presubmit successful).