Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 944553002: Fix the tests from the latest CL. (Closed)

Created:
5 years, 10 months ago by nweiz
Modified:
5 years, 10 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/unittest@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix the tests from the latest CL. This ensures that console_reporter_test isn't run on browsers, and improves the path detection for test/io.dart. R=kevmoo@google.com Committed: https://github.com/dart-lang/unittest/commit/612ca3a09dc8a51f4bd1855ec161c7d7a2708933

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M .status View 1 chunk +1 line, -0 lines 0 comments Download
M test/io.dart View 1 2 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
5 years, 10 months ago (2015-02-19 21:16:30 UTC) #1
kevmoo
lgtm https://codereview.chromium.org/944553002/diff/1/test/io.dart File test/io.dart (right): https://codereview.chromium.org/944553002/diff/1/test/io.dart#newcode33 test/io.dart:33: /// returned. Any libraries accessed must be added ...
5 years, 10 months ago (2015-02-19 22:54:18 UTC) #2
nweiz
Code review changes
5 years, 10 months ago (2015-02-19 23:17:30 UTC) #4
nweiz
https://codereview.chromium.org/944553002/diff/1/test/io.dart File test/io.dart (right): https://codereview.chromium.org/944553002/diff/1/test/io.dart#newcode33 test/io.dart:33: /// returned. Any libraries accessed must be added to ...
5 years, 10 months ago (2015-02-19 23:17:44 UTC) #5
nweiz
5 years, 10 months ago (2015-02-19 23:18:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
612ca3a09dc8a51f4bd1855ec161c7d7a2708933 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698