Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Issue 94453002: Fix unit tests. (Closed)

Created:
7 years ago by ngeoffray
Modified:
7 years ago
Reviewers:
lukas
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix unit tests. Use ioore instead of throw to recognize throwing a range error. The new IR now recognizes different int types. Committed: https://code.google.com/p/dart/source/detail?r=30753

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
tests/compiler/dart2js/constant_folding_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
tests/compiler/dart2js/issue13354_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
Committed patchset #1 manually as r30753 (presubmit successful).
7 years ago (2013-11-28 09:35:05 UTC) #1
ngeoffray
TBR
7 years ago (2013-11-28 09:35:15 UTC) #2
lukas
7 years ago (2013-11-28 11:30:45 UTC) #3
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698