Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 944423002: Revert "Use an enum in embedded_names as input to JS_GET_NAME." (Closed)

Created:
5 years, 10 months ago by karlklose
Modified:
5 years, 10 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Use an enum in embedded_names as input to JS_GET_NAME." This reverts commit r43869. BUG= http://dartbug.com/22495 R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=43943

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -82 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 3 chunks +0 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 1 chunk +12 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +4 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/js_lib/foreign_helper.dart View 2 chunks +1 line, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_helper.dart View 8 chunks +14 lines, -19 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_mirrors.dart View 7 chunks +6 lines, -8 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_names.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart View 1 chunk +2 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
5 years, 10 months ago (2015-02-23 08:23:23 UTC) #1
sigurdm
lgtm
5 years, 10 months ago (2015-02-23 08:28:55 UTC) #2
karlklose
5 years, 10 months ago (2015-02-23 08:29:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43943 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698