Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 943993005: Remove heap settings from pub scripts for SDK too. (Closed)

Created:
5 years, 10 months ago by Bob Nystrom
Modified:
5 years, 10 months ago
Reviewers:
nweiz, ahe
CC:
reviews_dartlang.org, Johnni Winther, aam-me
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove heap settings from pub scripts for SDK too. r43821 only does it for the scripts used to run pub from within the source repo. Also add support to the Windows shell script for passing VM flags to pub similar to what dart2js and the bash pub scripts allow. BUG=https://code.google.com/p/dart/issues/detail?id=22461 R=ahe@google.com, nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=43925

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M sdk/bin/pub.bat View 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/bin/pub_sdk View 1 chunk +0 lines, -4 lines 0 comments Download
M sdk/bin/pub_sdk.bat View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Bob Nystrom
I added you, Peter, because I think you're one of the few people on the ...
5 years, 10 months ago (2015-02-20 18:10:17 UTC) #2
ahe
I can see you copied this code from dart2js.bat, and that was tweaked by Johnni ...
5 years, 10 months ago (2015-02-20 18:34:25 UTC) #3
nweiz
lgtm Do we still need two separate scripts for these now that we don't do ...
5 years, 10 months ago (2015-02-20 19:03:48 UTC) #4
Bob Nystrom
On 2015/02/20 19:03:48, nweiz wrote: > lgtm > > Do we still need two separate ...
5 years, 10 months ago (2015-02-20 20:15:04 UTC) #5
Bob Nystrom
5 years, 10 months ago (2015-02-20 20:15:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43925 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698