Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 943723002: Return version with connected notification (Closed)

Created:
5 years, 10 months ago by Brian Wilkerson
Modified:
5 years, 10 months ago
Reviewers:
Paul Berry, jwren
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Touched missed Java files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -54 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServerListener.java View 1 1 chunk +3 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServerListenerAdapter.java View 1 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/BroadcastAnalysisServerListener.java View 1 1 chunk +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationServerConnectedProcessor.java View 1 2 chunks +13 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/MockAnalysisServerListener.java View 1 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/TestAnalysisServerListener.java View 1 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceAnalysisServerListener.java View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/doc/api.html View 4 chunks +15 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 4 chunks +38 lines, -37 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 1 chunk +49 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 2 chunks +7 lines, -1 line 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 1 chunk +8 lines, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 3 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Brian Wilkerson
5 years, 10 months ago (2015-02-19 20:00:59 UTC) #2
jwren
On 2015/02/19 20:00:59, Brian Wilkerson wrote: LGTM. I believe that the Java code needs to ...
5 years, 10 months ago (2015-02-19 20:06:50 UTC) #3
Paul Berry
lgtm
5 years, 10 months ago (2015-02-19 20:24:47 UTC) #4
Brian Wilkerson
PTAL > I believe that the Java code needs to be touched as well. I ...
5 years, 10 months ago (2015-02-19 20:38:16 UTC) #6
jwren
On 2015/02/19 20:38:16, Brian Wilkerson wrote: > PTAL > > > I believe that the ...
5 years, 10 months ago (2015-02-19 20:42:19 UTC) #7
Brian Wilkerson
5 years, 10 months ago (2015-02-19 20:45:25 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 43892 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698