Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 943503004: Added a test for issue 12474. (Closed)

Created:
5 years, 10 months ago by siva
Modified:
5 years, 10 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
A tests/isolate/browser/issue_12474_child.dart View 1 1 chunk +10 lines, -0 lines 0 comments Download
A tests/isolate/browser/issue_12474_test.dart View 1 1 chunk +24 lines, -0 lines 0 comments Download
A tests/isolate/browser/package/issue_12474_lib.dart View 1 1 chunk +7 lines, -0 lines 0 comments Download
M tests/isolate/isolate.status View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
siva
5 years, 10 months ago (2015-02-19 17:37:42 UTC) #2
siva
Moved tests under browser directory so that standalone skips it.
5 years, 10 months ago (2015-02-19 18:12:45 UTC) #3
vsm
lgtm
5 years, 10 months ago (2015-02-20 00:44:02 UTC) #4
siva
5 years, 10 months ago (2015-02-20 21:09:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r43929 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698