Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 943053005: Don't propose 'Assign to local variable' when in arguments list. (Closed)

Created:
5 years, 10 months ago by scheglov
Modified:
5 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't propose 'Assign to local variable' when in arguments list. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44036

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 10 months ago (2015-02-25 22:50:27 UTC) #1
Brian Wilkerson
LGTM
5 years, 10 months ago (2015-02-25 22:56:04 UTC) #2
scheglov
5 years, 10 months ago (2015-02-26 01:34:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44036 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698