Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 943043005: Do not allow abstract classes to be registered as custom elements (Closed)

Created:
5 years, 10 months ago by vsm
Modified:
5 years, 10 months ago
Reviewers:
terry, rmacnak
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Do not allow abstract classes to be registered as custom elements BUG=20813 R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=44007

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/dom/src/dartium_CustomElementSupport.dart View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
vsm
5 years, 10 months ago (2015-02-24 22:49:46 UTC) #2
rmacnak
lgtm
5 years, 10 months ago (2015-02-24 22:53:30 UTC) #3
vsm
5 years, 10 months ago (2015-02-24 22:58:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44007 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698