dart2js: remove optimization when computing required type checks.

dart2js: remove optimization when computing required type checks.

R=floitsch@google.com, herhut@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43950

[zarah, 2015-02-20 14:17:06]

zarah@google.com changed reviewers:
+ floitsch@google.com, herhut@google.com

[floitsch, 2015-02-20 14:21:59]

LGTM.
Watch golem after this commit, and make sure nothing increased unexpectedly in
code size.

[herhut, 2015-02-20 14:22:56]

lgtm w/ comments

https://codereview.chromium.org/942063002/diff/1/pkg/compiler/lib/src/js_back...
File pkg/compiler/lib/src/js_backend/runtime_types.dart (right):

https://codereview.chromium.org/942063002/diff/1/pkg/compiler/lib/src/js_back...
pkg/compiler/lib/src/js_backend/runtime_types.dart:260: Set<DartType>
instantiatedTypesAndClosures =
Maybe leave a comment that these are needed for is checks against function
types. That was clear from the predicate before.

[zarah, 2015-02-23 09:11:02]

New patchsets have been uploaded after l-g-t-m from
floitsch@google.com,herhut@google.com

[zarah, 2015-02-23 09:12:39]

https://codereview.chromium.org/942063002/diff/1/pkg/compiler/lib/src/js_back...
File pkg/compiler/lib/src/js_backend/runtime_types.dart (right):

https://codereview.chromium.org/942063002/diff/1/pkg/compiler/lib/src/js_back...
pkg/compiler/lib/src/js_backend/runtime_types.dart:260: Set<DartType>
instantiatedTypesAndClosures =
On 2015/02/20 14:22:56, herhut wrote:
> Maybe leave a comment that these are needed for is checks against function
> types. That was clear from the predicate before.

Done.

[zarah, 2015-02-23 11:46:07]

Committed patchset #3 (id:40001) manually as 43950 (presubmit successful).