Issue 94173002: Reduce running time of num_parse_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 94173002: Reduce running time of num_parse_test. (Closed)

Created:
7 years ago by Lasse Reichstein Nielsen

Modified:
7 years ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reduce running time of num_parse_test. It times out on Dartium. It was testing all combinations of whitespace around all test strings. Now it just does it around some representable test strings, and only test space characters around most strings. Also add a few more tests.

Patch Set 1 #

Patch Set 2 : Typo #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -1 line)			Patch
		tests/corelib/num_parse_test.dart	View	1	6 chunks	+33 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

7 years ago (2013-11-28 08:57:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r30749 (presubmit successful).

Expand Messages | Collapse Messages