Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 941123002: Get all tests running via the test runner. (Closed)

Created:
5 years, 10 months ago by nweiz
Modified:
5 years, 10 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/unittest@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Get all tests running via the test runner. The biggest issue was issue 6610 causing [Isolate.spawn] to fail in child isolates. R=kevmoo@google.com Committed: https://github.com/dart-lang/unittest/commit/0f69bf38f69ee51e07c7f3ac620cdde5768fa145

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -17 lines) Patch
M lib/src/dart.dart View 2 chunks +22 lines, -16 lines 0 comments Download
A lib/src/isolate_wrapper.dart View 1 chunk +44 lines, -0 lines 0 comments Download
M test/invoker_test.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 10 months ago (2015-02-19 23:54:24 UTC) #1
kevmoo
lgtm
5 years, 10 months ago (2015-02-20 00:21:01 UTC) #2
nweiz
5 years, 10 months ago (2015-02-20 00:33:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0f69bf38f69ee51e07c7f3ac620cdde5768fa145 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698