Issue 94093007: Add stack chain support to pkg/watcher and pkg/http.

Issue 94093007: Add stack chain support to pkg/watcher and pkg/http. (Closed)

Created:
7 years ago by nweiz

Modified:
7 years ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add stack chain support to pkg/watcher and pkg/http. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=30912

Patch Set 1 #

Total comments: 2

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -16 lines)			Patch
M	pkg/http/lib/src/base_client.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/http/lib/src/io_client.dart	View	3 chunks	+5 lines, -2 lines	0 comments	Download
M	pkg/http/lib/src/multipart_file.dart	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	pkg/http/lib/src/utils.dart	View	2 chunks	+5 lines, -0 lines	2 comments	Download
M	pkg/http/pubspec.yaml	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/watcher/lib/src/directory_watcher/linux.dart	View	3 chunks	+6 lines, -4 lines	0 comments	Download
M	pkg/watcher/lib/src/directory_watcher/mac_os.dart	View	3 chunks	+6 lines, -4 lines	0 comments	Download
M	pkg/watcher/lib/src/directory_watcher/polling.dart	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	pkg/watcher/lib/src/stat.dart	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	pkg/watcher/pubspec.yaml	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM. https://codereview.chromium.org/94093007/diff/1/pkg/http/lib/src/utils.dart File pkg/http/lib/src/utils.dart (right): https://codereview.chromium.org/94093007/diff/1/pkg/http/lib/src/utils.dart#newcode220 pkg/http/lib/src/utils.dart:220: Future syncFuture(callback()) => Chain.track(new Future.sync(callback)); Maybe this should ...

7 years ago (2013-12-05 17:35:46 UTC) #2

nweiz

https://codereview.chromium.org/94093007/diff/1/pkg/http/lib/src/utils.dart File pkg/http/lib/src/utils.dart (right): https://codereview.chromium.org/94093007/diff/1/pkg/http/lib/src/utils.dart#newcode220 pkg/http/lib/src/utils.dart:220: Future syncFuture(callback()) => Chain.track(new Future.sync(callback)); On 2013/12/05 17:35:46, Bob ...

7 years ago (2013-12-05 19:27:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r30912 (presubmit successful).

Expand Messages | Collapse Messages