Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1350)

Issue 940863002: - Allow any implementation of StackTrace to participate in async/ (Closed)

Created:
5 years, 10 months ago by Ivan Posva
Modified:
5 years, 10 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Allow any implementation of StackTrace to participate in async/ await exception handling. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=43880

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -15 lines) Patch
M runtime/vm/code_generator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/exceptions.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/exceptions.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/object.h View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +1 line, -1 line 0 comments Download
A tests/language/custom_await_stack_trace_test.dart View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Ivan Posva
5 years, 10 months ago (2015-02-19 06:46:23 UTC) #2
hausner
lgtm
5 years, 10 months ago (2015-02-19 07:08:53 UTC) #3
kevmoo
On 2015/02/19 07:08:53, hausner wrote: > lgtm Woo hoo!
5 years, 10 months ago (2015-02-19 16:00:13 UTC) #4
Ivan Posva
5 years, 10 months ago (2015-02-19 16:18:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r43880 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698