Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 940853002: Issue 22409. Restore recognizing string concatenation in const expressions. (Closed)

Created:
5 years, 10 months ago by scheglov
Modified:
5 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -68 lines) Patch
M pkg/analyzer/lib/src/generated/constant.dart View 7 chunks +32 lines, -20 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 16 chunks +46 lines, -45 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 10 months ago (2015-02-19 05:50:02 UTC) #1
Brian Wilkerson
LGTM
5 years, 10 months ago (2015-02-19 14:48:00 UTC) #2
scheglov
5 years, 10 months ago (2015-02-19 15:36:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43879 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698