Issue 940313003: Add File.modificationStamp accessor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 940313003: Add File.modificationStamp accessor. (Closed)

Created:
5 years, 10 months ago by scheglov

Modified:
5 years, 10 months ago

Reviewers:
danrubel, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add File.modificationStamp accessor. Dan, I noticed that you're using createSource().modification stamp to access this information. So, we need a more direct way to get it. R=brianwilkerson@google.com, danrubel@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43968

Patch Set 1 #

Total comments: 2

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+97 lines, -29 lines)			Patch
M	pkg/analyzer/lib/file_system/file_system.dart	View	2 chunks	+19 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/file_system/memory_file_system.dart	View	4 chunks	+26 lines, -24 lines	2 comments	Download
M	pkg/analyzer/lib/file_system/physical_file_system.dart	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/file_system/memory_file_system_test.dart	View	5 chunks	+26 lines, -5 lines	0 comments	Download
M	pkg/analyzer/test/file_system/physical_resource_provider_test.dart	View	2 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/940313003/diff/1/pkg/analyzer/lib/file_system/memory_file_system.dart File pkg/analyzer/lib/file_system/memory_file_system.dart (right): https://codereview.chromium.org/940313003/diff/1/pkg/analyzer/lib/file_system/memory_file_system.dart#newcode149 pkg/analyzer/lib/file_system/memory_file_system.dart:149: return -1; Should this throw an exception? Is ...

5 years, 10 months ago (2015-02-23 17:29:54 UTC) #3

scheglov

5 years, 10 months ago (2015-02-23 18:40:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 43968 (presubmit successful).

Expand Messages | Collapse Messages