Issue 939823002: Return RequestErrorCode.NO_INDEX_GENERATED if no index.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 939823002: Return RequestErrorCode.NO_INDEX_GENERATED if no index. (Closed)

Created:
5 years, 10 months ago by scheglov

Modified:
5 years, 10 months ago

Reviewers:
danrubel, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -1 line)			Patch
	M	pkg/analysis_server/lib/src/domain_completion.dart	View		4 chunks	+10 lines, -1 line	0 comments	Download
	M	pkg/analysis_server/test/domain_completion_test.dart	View		3 chunks	+30 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Brian Wilkerson

LGTM. At some point we might want to allow completions that don't require an index ...

5 years, 10 months ago (2015-02-18 23:02:54 UTC) #2

scheglov

5 years, 10 months ago (2015-02-19 05:07:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 43866 (presubmit successful).